refactor(rpc): make BlockRange.block_to required#2056
Merged
Conversation
Clients are now expected to either query the status of the node or sync the chain with `SyncChainMmr` before making other sync queries. This means that the chain tip will always be known to the client when making requests containing `BlockRange` so we can make `block_to` required.
Mirko-von-Leipzig
approved these changes
May 6, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Just the comment fixup
SantiagoPittella
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the RPC API lock-in clients are now expected to either query the status of the node or sync the chain with
SyncChainMmrbefore making other sync queries.This means that the chain tip will always be known to the client when making requests containing
BlockRangeso we can makeblock_torequired.